Re: [PATCH] gitweb: snapshot cleanups & support for offering multiple formats

From: Matt McCutchen <hashproduct@gmail.com>
Date: Jul 9, 2007, 22:52 UTC
Message-ID: <3bbc18d20707091552l29fb81b6v34da9cef3ec0df58@mail.gmail.com>
In-Reply-To: <7v1wfi1rz6.fsf@assigned-by-dhcp.cox.net>

On 7/8/07, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Matt McCutchen <hashproduct@gmail.com> writes:
>
> > -sub gitweb_have_snapshot {
> > -     my ($ctype, $suffix, $command) = gitweb_check_feature('snapshot');
> > -     my $have_snapshot = (defined $ctype && defined $suffix);
> > -
> > -     return $have_snapshot;
>
> Although you are removing this function, you still have a couple
> of callers left in the code.

OK, I will revise the patch, submit it and see if I can get it to appear as a reply to this thread. Incidentally, when only one format is offered, would you prefer the snapshot link to appear as "_snapshot_" (the same as before) or "_snapshot (tgz)_" instead of the "snapshot (_tgz_)" that the current patch does?

Matt