Re: [RFC/PATCH] gitweb: Enable transparent compression form HTTP output

From: Petr Baudis <pasky@suse.cz>
Date: Aug 25, 2007, 18:03 UTC
Message-ID: <20070825180350.GA1219@pasky.or.cz>
In-Reply-To: <200707252039.44312.jnareb@gmail.com>

On Wed, Jul 25, 2007 at 08:39:43PM CEST, Jakub Narebski wrote:

> Check if PerlIO::gzip is available, and if it is make it possible to

It doesn't really check if the require succeeded. Either the description or (preferrably, but not a showstopper, IMO) the code should be adjusted.

Show 5 quoted lines

> enable (via 'compression' %feature) transparent compression of HTML
> output.  Error messages and any non-HTML output are excluded from
> transparent compression.
> 
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>

Acked-by: Petr Baudis <pasky@suse.cz>

I'd put it on repo.or.cz... too bad that there I value CPU much more than the bandwidth. ;-)

Why did you exclude non-HTML output from transparent compression? Me and I guess other people too sometimes download rather large chunks of raw data over gitweb.

-- 
				Petr "Pasky" Baudis
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett