Re: [PATCH 3/3] unpack-trees: remove redundant path search in verify_absent

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2009, 08:19 UTC
Message-ID: <7viqoskft7.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1230843273-11056-4-git-send-email-drizzd@aon.at>

Clemens Buchacher <drizzd@aon.at> writes:

> Since the only caller, verify_absent, relies on the fact that o->pos
> points to the next index entry anyways, there is no need to recompute
> its position.

I suspect that the original reasoning of this behaviour might have been in anticipation of other callers, but I agree with your reasoning especially because I do not think of a good reason to want to receive the number of entries to skip as the return value and not have o->pos pointing at the right place.

Thanks, queued.