Re: [PATCH] Handle deltified object correctly in git-*-pull family.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jun 2, 2005, 18:02 UTC
- Message-ID
- <7vhdgg7i2a.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <1117731830.32257.52.camel@jmcmullan.timesys>
>>>>> "JM" == McMullan, Jason <jason.mcmullan@timesys.com> writes:
JM> Eww. Don't you want to attempt to get the referenced sha1 *before* JM> you stick the delta blob into the repository?
That issue crossed my mind, and I admit I haven't looked at the issues closely enough, but I suspect that it may not worth it with the current pull.c structure.
The current pull code fetches and stores a commit object before it retrieves the tree object associate with it, and similarly a tree object before its subtree and blobs, which has the same issue. Adding -r (recover) option to the pull family to not check for the existence of required object but its dependents would be necessary if my suspition turns out to be correct, and delta dependency should be handled the same way commit and tree dependencies are handled there.