Re: [PATCH] Use correct U*MAX.
- From
Petr Baudis <pasky@ucw.cz>
- Date
- Jun 3, 2005, 23:02 UTC
- Message-ID
- <20050603230234.GC13093@pasky.ji.cz>
- In-Reply-To
- <7vwtpc7lju.fsf_-_@assigned-by-dhcp.cox.net>
Dear diary, on Thu, Jun 02, 2005 at 06:47:33PM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...
Show 24 quoted lines
> The largest "unsigned long" value is ULONG_MAX, not UINT_MAX.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>
> diff --git a/diff.c b/diff.c
> --- a/diff.c
> +++ b/diff.c
> @@ -256,7 +256,7 @@ static struct sha1_size_cache *locate_si
> first = next+1;
> }
> /* not found */
> - if (size == UINT_MAX)
> + if (size == ULONG_MAX)
> return NULL;
> /* insert to make it at "first" */
> if (sha1_size_cache_alloc <= sha1_size_cache_nr) {
> @@ -338,7 +338,7 @@ int diff_populate_filespec(struct diff_f
> struct sha1_size_cache *e;
>
> if (size_only) {
> - e = locate_size_cache(s->sha1, UINT_MAX);
> + e = locate_size_cache(s->sha1, ULONG_MAX);
> if (e) {
> s->size = e->size;
> return 0;This one still applies, but it might be better to get rid of it altogether, like...
[PATCH] Kill UINT_MAX usage in locate_size_cache()
Use -1 instead of UINT_MAX to indicate that locate_size_cache() should do only the lookup and not create new stuff in case the looked up hash was not found.
Signed-off-by: Petr Baudis <pasky@ucw.cz>
diff --git a/diff.c b/diff.c --- a/diff.c +++ b/diff.c @@ -256,7 +256,7 @@ static struct sha1_size_cache *locate_si first = next+1; } /* not found */ - if (size == UINT_MAX) + if (size == -1) return NULL; /* insert to make it at "first" */ if (sha1_size_cache_alloc <= sha1_size_cache_nr) { @@ -337,7 +337,7 @@ int diff_populate_filespec(struct diff_f struct sha1_size_cache *e; if (size_only) { - e = locate_size_cache(s->sha1, UINT_MAX); + e = locate_size_cache(s->sha1, -1); if (e) { s->size = e->size; return 0; |
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor