Re: [PATCH v4] Allow update hooks to update refs on their own.

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 5, 2007, 22:19 UTC
Message-ID: <7vhciwn5rl.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <5920F34B-A94B-4C24-A95B-D35F35A4F0C0@midwinter.com>

Steven Grimm <koreth@midwinter.com> writes:

Show 15 quoted lines

> On Dec 2, 2007, at 6:16 PM, Junio C Hamano wrote:
>>> ..., but an
>>> "ok, but btw I changed your commit" status from receive-pack seems
>>> like
>>> it would be useful, for two reasons:
>> Sensible argument.  I stand corrected.
>
> If we want that status in principle, I'd argue that sending down the
> updated commit SHA1 is actually the right way to indicate it, because
> it gives the client all the information it needs to make an
> intelligent choice about what to do next. If you don't transmit the
> modified SHA1, the client will have to do another fetch to find out
> what rewriting was done by the server, and if another push happened in
> the meantime, the client will have to basically guess about which
> commits correspond to the ones it pushed.

Ok, but the output from fetch is meant to be human readable and we do not promise parsability, so if we go this route (which I think you made a sensible argument for) we would need a hook on the pushing end to act on this (perhaps record the correspondence of pushed and rewritten sha1 somewhere for the hook's own use).