Re: [PATCH v4] Allow update hooks to update refs on their own.
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Dec 4, 2007, 01:55 UTC
- Message-ID
- <20071204015511.GX14735@spearce.org>
- In-Reply-To
- <7vmyssqrhk.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes: > > > This probably requires exporting the name of the ref we currently > > have locked in an environment variable (and teach lockfile.c it) > > so we can effectively do recursive locking. That way the update > > hook can still use git-update-ref to change the ref safely. > > Heh, I like that, although I suspect getting this right would mean the > topic should be post 1.5.4 (which I do not mind).
Yea, most likely.
Also I won't have any time in the near future to work on this implementation myself. I threw the idea out there in case someone else can find the time. I'm willing to do the work myself as I think its the right approach to use here for this update hook change, but I just don't see myself getting to it anytime before say Christmas...
Its slightly more involved then what Steven originally proposed, but I think it solves the problem better and gives us more room for future improvements where we may want/need something such as a recursive ref locking.
-- Shawn.