git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Makefile: clarify definition of TEST_OBJS

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 28, 2010, 21:17 UTC
Message-ID
<7vhbp1vz4u.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20100228091155.GB30143@progeny.tock>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 8 quoted lines
> Oddly enough, with or without this change the behavior of the Makefile
> is the same.  Since TEST_PROGRAMS is defined with delayed evaluation,
> the value of
>
>  TEST_OBJS := $(patsubst test-%$X,test-%.o,$(TEST_PROGRAMS))
>
> is independent of the value of $X when it is evaluated: the $X in the
> pattern and the $X in $(TEST_PROGRAMS) will simply always cancel out.
Ugh.  That is what I missed.  Thanks for explanation.

The mismerge fixed by [PATCH 1/2] comes from my rerere database, and thanks to J6t's earlier "rerere forget" work, I managed to fix it in preparation for the eventual merge to 'master'. I queued the fix-up directly on 'next' as well.

Previous: Jonathan Nieder
Message 8 of 8 in “Makefile: fix compilation of test programs under MinGW environment”
  1. Makefile: fix compilation of test programs under MinGW environmentMichael Lukashov, Feb 27, 2010
  2. Junio C HamanoFeb 27, 2010
  3. Michael LukashovFeb 27, 2010
  4. Junio C HamanoFeb 27, 2010
  5. Michael LukashovFeb 27, 2010
  6. 1/2 Makefile: fix definition of $(TEST_PROGRAMS) on WindowsJonathan Nieder, Feb 28, 2010
  7. 2/2 Makefile: clarify definition of TEST_OBJSJonathan Nieder, Feb 28, 2010
  8. Junio C HamanoFeb 28, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.