From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 28 Feb 2010 21:17:21 GMT
Subject: Re: [PATCH 2/2] Makefile: clarify definition of TEST_OBJS
Message-ID: <7vhbp1vz4u.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100228091155.GB30143@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Oddly enough, with or without this change the behavior of the Makefile
> is the same.  Since TEST_PROGRAMS is defined with delayed evaluation,
> the value of
>
>  TEST_OBJS := $(patsubst test-%$X,test-%.o,$(TEST_PROGRAMS))
>
> is independent of the value of $X when it is evaluated: the $X in the
> pattern and the $X in $(TEST_PROGRAMS) will simply always cancel out.

Ugh.  That is what I missed.  Thanks for explanation.

The mismerge fixed by [PATCH 1/2] comes from my rerere database, and
thanks to J6t's earlier "rerere forget" work, I managed to fix it in
preparation for the eventual merge to 'master'.  I queued the fix-up
directly on 'next' as well.