Re: [PATCH] Makefile: fix compilation of test programs under MinGW environment

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2010, 21:31 UTC
Message-ID: <7vy6ietlf7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1267304969-1924-1-git-send-email-michael.lukashov@gmail.com>

Michael Lukashov <michael.lukashov@gmail.com> writes:

Show 7 quoted lines

> Commit 225f78c8 (Merge branch 'master' of git://repo.or.cz/alt-git
> into jn/autodep, 2010-01-26) changed Makefile in such a way that
> the following error occurs when trying to compile Git under MinGW environment:
>
>   make: *** No rule to make target `test-chmtime', needed by `all'.  Stop.
>
> Under Linux it seems there's no difference between two variants.

> -TEST_PROGRAMS := $(patsubst %,%$X,$(TEST_PROGRAMS_NEED_X))
> +TEST_PROGRAMS = $(patsubst %,%$X,$(TEST_PROGRAMS_NEED_X))

If the difference were on the RHS of this definition, which does involve $X that is different between the two platforms, I would understand, but your patch looks like it is addressing difference between := vs =, and that is more like a difference of other parts of the Makefile than difference between Linux and mingw compilation environment.

Does mingw build add other instances of TEST_PROGRAMS definition to the Makefile, or perhaps have other means (e.g. ./build.sh runs make with TEST_PROGRAMS set to something else) to affect it?

Or somewhere other than the main makefile, do you have an explicit "make test-chmtime" (not "make test-chmtime.exe") that tries to make sure that the build is done?