git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Submodules: Use "ignore" settings from .gitmodules too for diff and status

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 28, 2010, 21:35 UTC
Message-ID
<7vhbjjware.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4C4DD3CF.9070906@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
> The .gitmodules file is parsed for "submodule.<name>.ignore" entries
> before looking for them in .git/config. Thus settings found in .git/config
> will override those from .gitmodules,...
Hmph.

The value of "submodule.<name>.path" does not have to be "<name>". There seems to be a bit of confusion here.

I thought that [PATCH 1/2] used the path to the submodule, not its name, as the key. Even though the patch to Documentation/config.txt talks about "submodule.<submodulename>.ignore", what the code actually seems to do in set-from-submodule-config is to use path. 

But this patch seems to key off of <name>.

I suspect that it would make more sense to use <name> so that once the user configures ignore in .git/config, it will persist across moving of the submodule in the superproject tree.

In either case, we would want to be consistent between the two, no?
Previous: Jens LehmannNext: Jens Lehmann
Message 4 of 15 in “Submodules: Add the new config option "ignore"”
  1. 0/2 Submodules: Add the new config option "ignore"Jens Lehmann, Jul 26, 2010
  2. 1/2 Submodules: Add the new "ignore" config option for diff and statusJens Lehmann, Jul 26, 2010
  3. 2/2 Submodules: Use "ignore" settings from .gitmodules too for diff and statusJens Lehmann, Jul 26, 2010
  4. Junio C HamanoJul 28, 2010
  5. 0/2 Submodules: Add the new config option "ignore"Jens Lehmann, Aug 5, 2010
  6. 1/2 Submodules: Add the new "ignore" config option for diff and statusJens Lehmann, Aug 5, 2010
  7. 2/2 Submodules: Use "ignore" settings from .gitmodules too for diff and statusJens Lehmann, Aug 5, 2010
  8. Junio C HamanoAug 5, 2010
  9. Jens LehmannAug 5, 2010
  10. Junio C HamanoAug 9, 2010
  11. Johannes SchindelinAug 5, 2010
  12. Junio C HamanoAug 5, 2010
  13. Jens LehmannAug 5, 2010
  14. Add tests for the diff.ignoreSubmodules config optionJens Lehmann, Aug 5, 2010
  15. Junio C HamanoAug 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.