From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 28 Jul 2010 21:35:01 GMT
Subject: Re: [PATCH 2/2] Submodules: Use "ignore" settings from .gitmodules too for diff and status
Message-ID: <7vhbjjware.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4C4DD3CF.9070906@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

> The .gitmodules file is parsed for "submodule.<name>.ignore" entries
> before looking for them in .git/config. Thus settings found in .git/config
> will override those from .gitmodules,...

Hmph.

The value of "submodule.<name>.path" does not have to be "<name>".  There
seems to be a bit of confusion here.

I thought that [PATCH 1/2] used the path to the submodule, not its name,
as the key.  Even though the patch to Documentation/config.txt talks about
"submodule.<submodulename>.ignore", what the code actually seems to do in
set-from-submodule-config is to use path.  

But this patch seems to key off of <name>.

I suspect that it would make more sense to use <name> so that once the
user configures ignore in .git/config, it will persist across moving of
the submodule in the superproject tree.

In either case, we would want to be consistent between the two, no?