Re: [PATCH v2 0/2] Submodules: Add the new config option "ignore"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 9, 2010, 16:57 UTC
- Message-ID
- <7v7hjz7mhv.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4C5B4E80.1070102@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 16 quoted lines
> Am 06.08.2010 01:27, schrieb Junio C Hamano: >> Jens Lehmann <Jens.Lehmann@web.de> writes: >> >>> Am 28.07.2010 23:35, schrieb Junio C Hamano: >>>> The value of "submodule.<name>.path" does not have to be "<name>". There >>>> seems to be a bit of confusion here. >>> >>> Thanks for clearing up my confusion, this is v2 of this patch using the >>> path configured for the submodule instead of its name. >> >> Hmph, I thought that it would make more sense to use <name> so that once >> the user configures ignore in .git/config, it will persist across moving >> of the submodule in the superproject tree. I wonder what others would >> think. > > I think that is just what this patch does, it uses the ...
Yeah, what you said is all correct. I just misread "... this patch using the path ... instead of its name" to mean that the user-level interface is now keying off of a path, but that is not what you meant. You instead meant that the name is used as the key and it used as if it is a path in the previous round, but now it goes through name-to-path mapping.
Thanks.