git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: inform the user they can re-order commits

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 16, 2012, 14:46 UTC
Message-ID
<7vhaxoioxw.fsf@alter.siamese.dyndns.org>
In-Reply-To
<vpq3998ehp3.fsf@bauges.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 19 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>
>>> But if the user sees the help message of "rebase -i", then I don't think
>>> we will stop him from breaking anything by not mentionning that
>>> reordering commits can work. We already give other commands that rewrite
>>> history with more or less danger, so the additional messages isn't
>>> really harmful.
>>
>> I was not questioning that "You can also reorder" is dangerous in any way.
>>
>> What is dangerous is to give an illusion that it is safe to use "rebase
>> -i" without reading a decent documentation that does not even say that
>> reordering is one of the primary purpose of the command, and the mindset
>> that it is OK to give such an illusion with these reminder lines.
>
> Yes, but my point is that you can already do that. Nelson just gave an
> example when explaining how he came out with this patch.
Yes, I know that.

And a patch like this will _encourage_ the users to follow that path even more. Is it a good thing? That is what I was questioning.

Previous: Matthieu MoyNext: Junio C Hamano
Message 11 of 15 in “rebase -i: inform the user they can re-order commits”
  1. rebase -i: inform the user they can re-order commitsNelson Benitez Leon, Mar 16, 2012
  2. Matthieu MoyMar 16, 2012
  3. Nelson Benitez LeonMar 16, 2012
  4. Matthieu MoyMar 16, 2012
  5. Jakub NarebskiMar 16, 2012
  6. Junio C HamanoMar 16, 2012
  7. Nelson Benitez LeonMar 16, 2012
  8. Matthieu MoyMar 16, 2012
  9. Junio C HamanoMar 16, 2012
  10. Matthieu MoyMar 16, 2012
  11. Junio C HamanoMar 16, 2012
  12. Junio C HamanoMar 16, 2012
  13. Junio C HamanoMar 20, 2012
  14. Matthieu MoyMar 21, 2012
  15. Philip OakleyMar 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.