git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: inform the user they can re-order commits

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 16, 2012, 12:17 UTC
Message-ID
<7vty1oivub.fsf@alter.siamese.dyndns.org>
In-Reply-To
<vpqlin0n8w5.fsf@bauges.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 7 quoted lines
> Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:
>
>> +# You can re-order the commit lines to affect the order on which
>> +# the commits will be applied.
>
> That's probably the main use of "rebase -i", so it deserves a mention,
> yes.

Erm, read in isolation by people like you who _know_ what the command does, the addition might look sensible, but I find that line of thinking somewhat disturbing in the first place.

These are meant to be a short _reminder_ for people who _learned_ how the command they already _know_ is spelled.

If the user does not even know that one of the primary use of the command is to reorder, isn't he playing with fire?

If we come up with a politely worded message that makes the user realize that the user does not know what he is doing and gently nudges the user to read the documentation before continuing to potentially harm himself, that would be a good addition, but...

So, I dunno.
Previous: Jakub NarebskiNext: Nelson Benitez Leon
Message 6 of 15 in “rebase -i: inform the user they can re-order commits”
  1. rebase -i: inform the user they can re-order commitsNelson Benitez Leon, Mar 16, 2012
  2. Matthieu MoyMar 16, 2012
  3. Nelson Benitez LeonMar 16, 2012
  4. Matthieu MoyMar 16, 2012
  5. Jakub NarebskiMar 16, 2012
  6. Junio C HamanoMar 16, 2012
  7. Nelson Benitez LeonMar 16, 2012
  8. Matthieu MoyMar 16, 2012
  9. Junio C HamanoMar 16, 2012
  10. Matthieu MoyMar 16, 2012
  11. Junio C HamanoMar 16, 2012
  12. Junio C HamanoMar 16, 2012
  13. Junio C HamanoMar 20, 2012
  14. Matthieu MoyMar 21, 2012
  15. Philip OakleyMar 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.