From: Junio C Hamano Date: Fri, 16 Mar 2012 14:46:19 GMT Subject: Re: [PATCH] rebase -i: inform the user they can re-order commits Message-ID: <7vhaxoioxw.fsf@alter.siamese.dyndns.org> In-Reply-To: Matthieu Moy writes: > Junio C Hamano writes: > >> Matthieu Moy writes: >> >>> But if the user sees the help message of "rebase -i", then I don't think >>> we will stop him from breaking anything by not mentionning that >>> reordering commits can work. We already give other commands that rewrite >>> history with more or less danger, so the additional messages isn't >>> really harmful. >> >> I was not questioning that "You can also reorder" is dangerous in any way. >> >> What is dangerous is to give an illusion that it is safe to use "rebase >> -i" without reading a decent documentation that does not even say that >> reordering is one of the primary purpose of the command, and the mindset >> that it is OK to give such an illusion with these reminder lines. > > Yes, but my point is that you can already do that. Nelson just gave an > example when explaining how he came out with this patch. Yes, I know that. And a patch like this will _encourage_ the users to follow that path even more. Is it a good thing? That is what I was questioning.