git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/mingw.h: Set S_ISUID to prevent a fast-import test failure

From
Junio C Hamano <gitster@pobox.com>
Date
May 1, 2012, 14:30 UTC
Message-ID
<7vhaw0as8e.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4F8F2268.8020803@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 13 quoted lines
>> ...
>> -#define S_ISGID 0
>> -#define S_ISVTX 0
>> +
>> +#define S_ISUID 0004000
>> +#define S_ISGID 0002000
>> +#define S_ISVTX 0001000
>>  
>>  #define WIFEXITED(x) 1
>>  #define WIFSIGNALED(x) 0
>
> I've submitted a similar patch, but it was suggested to solve the
> inherent problem in a cleaner way, but no patch came forward.

I think this patch should be fine, either as the final solution, or the first step for "solving the inherent problem in a cleaner way" (if msysgit folk care very deeply about it, that is).

Previous: Johannes SixtNext: Johannes Sixt
Message 3 of 4 in “compat/mingw.h: Set S_ISUID to prevent a fast-import test failure”
  1. compat/mingw.h: Set S_ISUID to prevent a fast-import test failureRamsay Jones, Apr 17, 2012
  2. Johannes SixtApr 18, 2012
  3. Junio C HamanoMay 1, 2012
  4. Johannes SixtMay 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.