From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 01 May 2012 14:30:41 GMT
Subject: Re: [PATCH] compat/mingw.h: Set S_ISUID to prevent a fast-import test failure
Message-ID: <7vhaw0as8e.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F8F2268.8020803@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

>> ...
>> -#define S_ISGID 0
>> -#define S_ISVTX 0
>> +
>> +#define S_ISUID 0004000
>> +#define S_ISGID 0002000
>> +#define S_ISVTX 0001000
>>  
>>  #define WIFEXITED(x) 1
>>  #define WIFSIGNALED(x) 0
>
> I've submitted a similar patch, but it was suggested to solve the
> inherent problem in a cleaner way, but no patch came forward.

I think this patch should be fine, either as the final solution, or the
first step for "solving the inherent problem in a cleaner way" (if msysgit
folk care very deeply about it, that is).