git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/mingw.h: Set S_ISUID to prevent a fast-import test failure

From
Johannes Sixt <j6t@kdbg.org>
Date
May 1, 2012, 19:44 UTC
Message-ID
<4FA03D0F.6080906@kdbg.org>
In-Reply-To
<7vhaw0as8e.fsf@alter.siamese.dyndns.org>
Am 01.05.2012 16:30, schrieb Junio C Hamano:
Show 19 quoted lines
> Johannes Sixt<j6t@kdbg.org>  writes:
>
>>> ...
>>> -#define S_ISGID 0
>>> -#define S_ISVTX 0
>>> +
>>> +#define S_ISUID 0004000
>>> +#define S_ISGID 0002000
>>> +#define S_ISVTX 0001000
>>>
>>>   #define WIFEXITED(x) 1
>>>   #define WIFSIGNALED(x) 0
>>
>> I've submitted a similar patch, but it was suggested to solve the
>> inherent problem in a cleaner way, but no patch came forward.
>
> I think this patch should be fine, either as the final solution, or the
> first step for "solving the inherent problem in a cleaner way" (if msysgit
> folk care very deeply about it, that is).

My primary concern is to have the bug fixed on Windows. For this purpose, this patch is sufficiently clean.

-- Hannes
Previous: Junio C Hamano
Message 4 of 4 in “compat/mingw.h: Set S_ISUID to prevent a fast-import test failure”
  1. compat/mingw.h: Set S_ISUID to prevent a fast-import test failureRamsay Jones, Apr 17, 2012
  2. Johannes SixtApr 18, 2012
  3. Junio C HamanoMay 1, 2012
  4. Johannes SixtMay 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.