Re: [PATCH] Change "refs/" references to symbolic constants

From: Junio C Hamano <junkio@cox.net>
Date: Feb 20, 2007, 09:50 UTC
Message-ID: <7vfy91ximy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200702200942.18654.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 13 quoted lines

> On Monday 2007 February 19 20:07, Junio C Hamano wrote:
>
>> > -	if (!strncmp(path, "refs/tags/", 10)) {
>> > +	if (!strncmp(path, PATH_TAGS, STRLEN_PATH_TAGS)) {
>> >  		if (object->type == OBJ_TAG)
>> >  			prio = 2;
>> >  		else
>>
>> This is PATH_REFS_TAGS isn't it?
>
> I'm uncomfortable that this one managed to get through; in view of this 
> mistake if you are thinking of applying this - don't.  I'm going to review 
> the patch itself line by line.

I'd send the prefixcmp() patches first, as yours would touch the same lines.

> Also - I should learn how to run the tests - is "make test"
> good enough or is there something special I should do?

Should be enough.