Re: [PATCH] Change "refs/" references to symbolic constants

From: Andy Parkins <andyparkins@gmail.com>
Date: Feb 20, 2007, 09:42 UTC
Message-ID: <200702200942.18654.andyparkins@gmail.com>
In-Reply-To: <7vlkit7vy5.fsf@assigned-by-dhcp.cox.net>

On Monday 2007 February 19 20:07, Junio C Hamano wrote:

Show 7 quoted lines

> > -	if (!strncmp(path, "refs/tags/", 10)) {
> > +	if (!strncmp(path, PATH_TAGS, STRLEN_PATH_TAGS)) {
> >  		if (object->type == OBJ_TAG)
> >  			prio = 2;
> >  		else
>
> This is PATH_REFS_TAGS isn't it?

I'm uncomfortable that this one managed to get through; in view of this mistake if you are thinking of applying this - don't. I'm going to review the patch itself line by line.

Also - I should learn how to run the tests - is "make test" good enough or is there something special I should do?

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIEE
andyparkins@gmail.com