git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] log and rev-list: Fixed newline termination issues with --graph

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 8, 2008, 00:58 UTC
Message-ID
<7vfxtxnovw.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<5d46db230804071725r44694e76l3d6e63aabc67f372@mail.gmail.com>
"Govind Salinas" <blix@sophiasuchtig.com> writes:
> Shouldn't whatever option is used here respect line_terminator such
> that it will use NULL bytes when -z is used?

Yes but it is orthogonal to what is being discussed. What the patch shows is how to allow --pretty=format: to conditionally do what --pretty=oneline already does. If the current --pretty=oneline forces "\n" under -z (I haven't checked if that is the case) that might be something we may want to change. Once you do so, you would get the same fix for --pretty=format for free ;-)

Also when you talk about line_terminator, you need to be careful to realize that it is _not_ really a "line_terminator". For example, we do not substitute 's/\n/\0/' the EOLN in multi-line log messages. Neither do we use NUL terminated lines in diff nor stat output when -p and --stat are in effect. They are more like "separator between parts of output".

Previous: Govind SalinasNext: Teemu Likonen
Message 18 of 37 in “Add history graph API”
  1. 1/4 Add history graph APIAdam Simpkins, Apr 6, 2008
  2. 2/4 graph API: Added additional utility functions to the graph APIAdam Simpkins, Apr 6, 2008
  3. 3/4 git log and git rev-list: Add --graph optionAdam Simpkins, Apr 6, 2008
  4. 4/4 git log: Updated --graph to work even when the commit list is prunedAdam Simpkins, Apr 6, 2008
  5. 5/5 Document the new --graph option for log and rev-listAdam Simpkins, Apr 6, 2008
  6. 1/4 graph API: Fixed coding style problemsAdam Simpkins, Apr 7, 2008
  7. 2/4 log and rev-list: Fixed newline termination issues with --graphAdam Simpkins, Apr 7, 2008
  8. 3/4 log and rev-list: Fix --graph output with --pretty=emailAdam Simpkins, Apr 7, 2008
  9. 4/4 log and rev-list: Improve --graph output when commits have been prunedAdam Simpkins, Apr 7, 2008
  10. Junio C HamanoApr 7, 2008
  11. Junio C HamanoApr 7, 2008
  12. Jeff KingApr 7, 2008
  13. Junio C HamanoApr 7, 2008
  14. Adam SimpkinsApr 7, 2008
  15. Jakub NarebskiApr 7, 2008
  16. Junio C HamanoApr 8, 2008
  17. Govind SalinasApr 8, 2008
  18. Junio C HamanoApr 8, 2008
  19. Teemu LikonenApr 6, 2008
  20. Adam SimpkinsApr 6, 2008
  21. Teemu LikonenApr 6, 2008
  22. Adam SimpkinsApr 6, 2008
  23. Johannes SchindelinApr 6, 2008
  24. Adam SimpkinsApr 6, 2008
  25. Teemu LikonenApr 7, 2008
  26. Adam SimpkinsApr 7, 2008
  27. Teemu LikonenApr 7, 2008
  28. Johannes SchindelinApr 6, 2008
  29. Adam SimpkinsApr 6, 2008
  30. Johannes SchindelinApr 6, 2008
  31. Adam SimpkinsApr 6, 2008
  32. Linus TorvaldsApr 7, 2008
  33. Junio C HamanoApr 7, 2008
  34. bash: Add command line completion of --graph (git log)Teemu Likonen, Apr 6, 2008
  35. bash: Add more command line option completions for 'git log'Teemu Likonen, Apr 7, 2008
  36. Teemu LikonenApr 7, 2008
  37. Adam SimpkinsApr 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.