git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] Add history graph API

From
Adam Simpkins <adam@adamsimpkins.net>
Date
Apr 6, 2008, 22:04 UTC
Message-ID
<20080406220447.GB5822@adamsimpkins.net>
In-Reply-To
<alpine.DEB.1.00.0804062204580.12583@eeepc-johanness>
On Sun, Apr 06, 2008 at 10:06:24PM +0100, Johannes Schindelin wrote:
Show 9 quoted lines
> 
> On Sun, 6 Apr 2008, Adam Simpkins wrote:
> 
> > +/* Defined in commit.h */
> > +struct commit;
> > +/* Defined in strbuf.h */
> > +struct strbuf;
> 
> You do not need those.

I added them so that graph.h can be included without including any other header files first. They can be taken out if we assume that all users of graph.h will include commit.h and strbuf.h first.

> Apart from that, it looks very, very clean to me.  (Except maybe the 
> prefix ++ that could have been a postfix ++ in the line before, but that 
> is just me.)

Sorry, force of habit. I tried to remember to use postfix in most places, but I guess I forgot in that place.

I do most of my programming in C++, which allows crazy things like defining prefix and postfix ++ and -- operators on classes. When using these on classes, the prefix operator is normally more efficient than the postfix version, so I'm just in the habit of using prefix increment everywhere. This can easily be changed if postfix is preferred for the git coding style.

-- 
Adam Simpkins
adam@adamsimpkins.net
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 29 of 37 in “Add history graph API”
  1. 1/4 Add history graph APIAdam Simpkins, Apr 6, 2008
  2. 2/4 graph API: Added additional utility functions to the graph APIAdam Simpkins, Apr 6, 2008
  3. 3/4 git log and git rev-list: Add --graph optionAdam Simpkins, Apr 6, 2008
  4. 4/4 git log: Updated --graph to work even when the commit list is prunedAdam Simpkins, Apr 6, 2008
  5. 5/5 Document the new --graph option for log and rev-listAdam Simpkins, Apr 6, 2008
  6. 1/4 graph API: Fixed coding style problemsAdam Simpkins, Apr 7, 2008
  7. 2/4 log and rev-list: Fixed newline termination issues with --graphAdam Simpkins, Apr 7, 2008
  8. 3/4 log and rev-list: Fix --graph output with --pretty=emailAdam Simpkins, Apr 7, 2008
  9. 4/4 log and rev-list: Improve --graph output when commits have been prunedAdam Simpkins, Apr 7, 2008
  10. Junio C HamanoApr 7, 2008
  11. Junio C HamanoApr 7, 2008
  12. Jeff KingApr 7, 2008
  13. Junio C HamanoApr 7, 2008
  14. Adam SimpkinsApr 7, 2008
  15. Jakub NarebskiApr 7, 2008
  16. Junio C HamanoApr 8, 2008
  17. Govind SalinasApr 8, 2008
  18. Junio C HamanoApr 8, 2008
  19. Teemu LikonenApr 6, 2008
  20. Adam SimpkinsApr 6, 2008
  21. Teemu LikonenApr 6, 2008
  22. Adam SimpkinsApr 6, 2008
  23. Johannes SchindelinApr 6, 2008
  24. Adam SimpkinsApr 6, 2008
  25. Teemu LikonenApr 7, 2008
  26. Adam SimpkinsApr 7, 2008
  27. Teemu LikonenApr 7, 2008
  28. Johannes SchindelinApr 6, 2008
  29. Adam SimpkinsApr 6, 2008
  30. Johannes SchindelinApr 6, 2008
  31. Adam SimpkinsApr 6, 2008
  32. Linus TorvaldsApr 7, 2008
  33. Junio C HamanoApr 7, 2008
  34. bash: Add command line completion of --graph (git log)Teemu Likonen, Apr 6, 2008
  35. bash: Add more command line option completions for 'git log'Teemu Likonen, Apr 7, 2008
  36. Teemu LikonenApr 7, 2008
  37. Adam SimpkinsApr 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.