Re: [PATCH 1/4] Add history graph API
- From
- Teemu Likonen <tlikonen@iki.fi>
- Date
- Apr 7, 2008, 08:56 UTC
- Message-ID
- <20080407085653.GB5413@mithlond.arda.local>
- In-Reply-To
- <20080407083412.GA9764@adamsimpkins.net>
Adam Simpkins kirjoitti (7.4.2008 klo 1.34):
Show 11 quoted lines
> The nicest way to fix this would probably be to write new diff API > functions that output to a strbuf instead of printing directly to > stdout. Then the log code could prefix each line of the buffer with > the graph info before printing it. > > However, this would be a lot of work, and I'm not sure that it's > really worth the effort at the moment. For now, I'm leaning towards > changing the code to just exit with an error if --graph is used with > any of these options. > > Any opinions? Alternative suggestions?
Ok, then I'd suggest that it's left as is. The --graph may be useful with some stat options even when the graph area is parially broken by some other output.