git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] i18n: avoid conflict with ngettext from libintl

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 9, 2011, 20:43 UTC
Message-ID
<7vfwqw9g9b.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110309105236.GC30980@elie>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 5 quoted lines
> To avoid having to worry about a conflicting ngettext symbol when
> libintl is part of libc, also rename the no-op ngettext stub to
> git_ngettext and make ngettext a macro referring to it.  This is
> probably never necessary (because git's ngettext is declared "static
> inline") but it buys peace of mind.

Hmph. An obviously safer alternative would be to use git_ngettext() in our source all over the place, and it would by even more peace of mind but that is even longer.

> This change does not protect against conflicts due to a header
> included _after_ git's i18n support (e.g., pthread.h) being the first
> to pull in libintl.  We can deal with that separately if it happens.
Also the same problem exists already for the _() macro.
Previous: Jonathan NiederNext: Jonathan Nieder
Message 28 of 34 in “[BUG] git-am silently applying patches incorrectly”
  1. Colin GuthrieMar 4, 2011
  2. Drew NorthupMar 4, 2011
  3. Colin GuthrieMar 4, 2011
  4. Junio C HamanoMar 4, 2011
  5. Junio C HamanoMar 4, 2011
  6. Junio C HamanoMar 4, 2011
  7. Junio C HamanoMar 4, 2011
  8. Linus TorvaldsMar 4, 2011
  9. Junio C HamanoMar 4, 2011
  10. Alexander MiselerMar 4, 2011
  11. Junio C HamanoMar 4, 2011
  12. Colin GuthrieMar 4, 2011
  13. Junio C HamanoMar 4, 2011
  14. Junio C HamanoMar 4, 2011
  15. Colin GuthrieMar 5, 2011
  16. Junio C HamanoMar 6, 2011
  17. Junio C HamanoMar 6, 2011
  18. Jonathan NiederMar 6, 2011
  19. Junio C HamanoMar 6, 2011
  20. Colin GuthrieMar 7, 2011
  21. Alexander MiselerMar 4, 2011
  22. Junio C HamanoMar 5, 2011
  23. Junio C HamanoMar 4, 2011
  24. Drew NorthupMar 4, 2011
  25. 0/2 i18n: add ngettext stubJonathan Nieder, Mar 9, 2011
  26. 1/2 i18n: add stub ngettext implementationJonathan Nieder, Mar 9, 2011
  27. 2/2 i18n: avoid conflict with ngettext from libintlJonathan Nieder, Mar 9, 2011
  28. Junio C HamanoMar 9, 2011
  29. Jonathan NiederMar 9, 2011
  30. Junio C HamanoMar 9, 2011
  31. i18n: add stub Q_() wrapper for ngettextJonathan Nieder, Mar 10, 2011
  32. Junio C HamanoMar 10, 2011
  33. Ævar Arnfjörð BjarmasonMar 10, 2011
  34. Ævar Arnfjörð BjarmasonMar 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.