From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 Mar 2011 20:43:28 GMT
Subject: Re: [PATCH 2/2] i18n: avoid conflict with ngettext from libintl
Message-ID: <7vfwqw9g9b.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110309105236.GC30980@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

> To avoid having to worry about a conflicting ngettext symbol when
> libintl is part of libc, also rename the no-op ngettext stub to
> git_ngettext and make ngettext a macro referring to it.  This is
> probably never necessary (because git's ngettext is declared "static
> inline") but it buys peace of mind.

Hmph.  An obviously safer alternative would be to use git_ngettext() in
our source all over the place, and it would by even more peace of mind but
that is even longer.

> This change does not protect against conflicts due to a header
> included _after_ git's i18n support (e.g., pthread.h) being the first
> to pull in libintl.  We can deal with that separately if it happens.

Also the same problem exists already for the _() macro.