[RFC/PATCH 0/2] i18n: add ngettext stub

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 9, 2011, 10:31 UTC
Message-ID: <20110309103104.GA30980@elie>
In-Reply-To: <AANLkTikctSrfqKCdeYUyvUmAZjr=i7kaFhPeB-LfwgUz@mail.gmail.com>

Junio C Hamano wrote:

> On Mar 6, 2011 3:07 PM, "Jonathan Nieder" <jrnieder@gmail.com> wrote:

Show 8 quoted lines

>> Yep.  Is it safe to do this without the
>>
>> #define ngettext git_ngettext
>> static inline const char *git_ngettext(...)
>>
>> dance?
>
> Heh you tell me.

Yegh. My general feeling was that we should make sure gettext.h works even if <libintl.h> was included elsewhere, just in case some system header decides to start including it. That makes life slightly less pleasant, since libintl.h does

 #if defined __OPTIMIZE__ && !defined __cplusplus
[...]
 # define ngettext(msgid1, msgid2, n) dngettext (NULL, msgid1, msgid2, n)
[...]
 #endif	/* Optimizing.  */

How about this?

Jonathan Nieder (1):
  i18n: avoid conflict with ngettext from libintl

Junio C Hamano (1):
  i18n: add no-op ngettext() fallback

 gettext.h |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

-- 
1.7.4.1