git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] fsck: improve committer/author check

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 2, 2011, 17:00 UTC
Message-ID
<7vfwljg33p.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1311831844-13123-6-git-send-email-divanorama@gmail.com>
Dmitry Ivankov <divanorama@gmail.com> writes:
Show 8 quoted lines
> Neither name nor email should contain < or >, so split the string with
> these and check they come in that order and < is preceeded with a space.
>
> If < is missing don't say a confusing "missing space", say "bad name" if
>> isn't missing and "missing email" if both < and > are missing.
>
> Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
> ---

Same comment as 3/5; before starting to talk about how you implemented your validation, please state what rules you are enforcing.

Thanks.
Previous: Dmitry IvankovNext: Dmitry Ivankov
Message 10 of 11 in “fixes for committer/author parsing/check”
  1. 0/5 fixes for committer/author parsing/checkDmitry Ivankov, Jul 28, 2011
  2. 1/5 fast-import: add input format testsDmitry Ivankov, Jul 28, 2011
  3. 2/5 fast-import: don't fail on omitted committer nameDmitry Ivankov, Jul 28, 2011
  4. Junio C HamanoAug 2, 2011
  5. Dmitry IvankovAug 2, 2011
  6. 3/5 fast-import: check committer name more strictlyDmitry Ivankov, Jul 28, 2011
  7. Junio C HamanoAug 2, 2011
  8. 4/5 fsck: add a few committer name testsDmitry Ivankov, Jul 28, 2011
  9. 5/5 fsck: improve committer/author checkDmitry Ivankov, Jul 28, 2011
  10. Junio C HamanoAug 2, 2011
  11. Dmitry IvankovAug 2, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.