git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] fast-import: check committer name more strictly

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 2, 2011, 17:01 UTC
Message-ID
<7v8vrbg32f.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1311831844-13123-4-git-send-email-divanorama@gmail.com>
Dmitry Ivankov <divanorama@gmail.com> writes:
> Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
> ---

Please describe how you check this field "more strictly" in the body of the log message, iow, against what rule you are validating, perhaps something like:

 The identifier must be either "<address>" or "Name <address>" where
 neither address nor Name can contain '<' nor '>'; otherwise the input
 stream is rejected.

As fast-import is used to _create_ new objects, its input is a simple text file that can be fixed-up as needed, it is a good idea to validate the input more strictly and rejecting bad ones.

Previous: Dmitry IvankovNext: Dmitry Ivankov
Message 7 of 11 in “fixes for committer/author parsing/check”
  1. 0/5 fixes for committer/author parsing/checkDmitry Ivankov, Jul 28, 2011
  2. 1/5 fast-import: add input format testsDmitry Ivankov, Jul 28, 2011
  3. 2/5 fast-import: don't fail on omitted committer nameDmitry Ivankov, Jul 28, 2011
  4. Junio C HamanoAug 2, 2011
  5. Dmitry IvankovAug 2, 2011
  6. 3/5 fast-import: check committer name more strictlyDmitry Ivankov, Jul 28, 2011
  7. Junio C HamanoAug 2, 2011
  8. 4/5 fsck: add a few committer name testsDmitry Ivankov, Jul 28, 2011
  9. 5/5 fsck: improve committer/author checkDmitry Ivankov, Jul 28, 2011
  10. Junio C HamanoAug 2, 2011
  11. Dmitry IvankovAug 2, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.