From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 02 Aug 2011 17:00:58 GMT
Subject: Re: [PATCH 5/5] fsck: improve committer/author check
Message-ID: <7vfwljg33p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1311831844-13123-6-git-send-email-divanorama@gmail.com>

Dmitry Ivankov <divanorama@gmail.com> writes:

> Neither name nor email should contain < or >, so split the string with
> these and check they come in that order and < is preceeded with a space.
>
> If < is missing don't say a confusing "missing space", say "bad name" if
>> isn't missing and "missing email" if both < and > are missing.
>
> Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
> ---

Same comment as 3/5; before starting to talk about how you implemented
your validation, please state what rules you are enforcing.

Thanks.