Re: [PATCH 1/2] git-svn: use platform specific auth providers

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2012, 21:44 UTC
Message-ID: <7vfwacxe7p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120603104914.GA21276@hashpling.org>

Charles Bailey <charles@hashpling.org> writes:

Show 31 quoted lines

>> @@ -5464,7 +5481,7 @@ sub _auth_providers () {
>>  
>>  	# earlier 1.6.x versions would segfault, and <= 1.5.x didn't have
>>  	# this function
>> -	if ($SVN::Core::VERSION gt '1.6.12') {
>> +	if (compare_svn_version('1.6.12') > 0) {
>>  		my $config = SVN::Core::config_get_config($config_dir);
>>  		my ($p, @a);
>>  		# config_get_config returns all config files from
>
> I presume this patch turned into this commit:
>
> commit f760c903b8525878cd3b426fc61a7a2cf8742609
> Author: Junio C Hamano <gitster@pobox.com>
> Date:   Wed May 2 19:53:50 2012 +0000
>
>     git-svn: introduce SVN version comparison function
>
> Although it was advertised as fixing the breakage introduced by
> 082afee621aeb2d3746c8ae290af98823f981f34 it didn't fix things for me.
> Although I haven't investigate why, trial and error proved that I
> could fix it if I changed the comparison to:
>
>        if (::compare_svn_version('1.6.13') > 0) {
>
> For me:
> $ svn --version --quiet
> 1.6.13
>
> Is this the correct fix or do I have a bad svn install on my linux
> box?

The conversion from "gt '1.6.12'" to "compare() > 0" is correct, I think, as the original wanted to make sure that you have 1.6.13 or newer (in other words, '1.6.12' is not good enough, but '1.6.13' is). The fix was about not doing string comparison between the version string and '1.6.12' string, i.e.

	if ("1.6.9" gt '1.6.12') {
		use the logic for newer versions
	}

incorrectly used the logic for newer versions. That was the only thing f760c90 (git-svn: introduce SVN version comparison function, 2012-05-02) addressed.

It is possible that '1.6.12' is not the right cut-off point and the logic may require a version newer than that but that is outside the scope of f760c90.

The cut-off point comes from 082afee (git-svn: use platform specific auth providers, 2012-04-26).

Matthijs?  Eric?