git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git-svn: use platform specific auth providers

From
Matthijs Kooijman <matthijs@stdin.nl>
Date
Apr 30, 2012, 19:20 UTC
Message-ID
<20120430192016.GQ4023@login.drsnuggles.stderr.nl>
In-Reply-To
<20120430190200.GA27108@dcvr.yhbt.net>
Hi Eric,
Show 6 quoted lines
> > This does textual comparison, so 1.6.6 > 1.6.12. To do proper version
> > comparison, I think the version numbers should be split into
> > major/minor/revision and each be compared numerically.
> 
> Ah, thanks for the analysis, we were lucky in the past that all version
> components only had a single character.

Indeed. Note that this includes the released subversion versions. For example, the code contains this check:

    $SVN::Core::VERSION le '1.5.4'

and 1.5.10 < 1.5.4. Fortunately, 1.5.9 was the last release in the 1.5 series, and no other checks compare against 1.6.x.

If subversion would ever reach the 1.10.x version number, things would also start breaking.

> I think the former is preferable for git.  Sort::Versions isn't used
> anywhere else in git and I don't think it's widely installed.
I guessed as much. I'll have a look at providing a patch.
Gr.
Matthijs
Previous: Eric WongNext: Junio C Hamano
Message 28 of 35 in “git-svn won't remember pem password”
  1. IgorFeb 18, 2012
  2. Jakub NarebskiFeb 18, 2012
  3. Nikolaus DemmelFeb 19, 2012
  4. Jeff KingFeb 20, 2012
  5. Nikolaus DemmelFeb 20, 2012
  6. Eric WongFeb 19, 2012
  7. Matthijs KooijmanApr 26, 2012
  8. IgorApr 26, 2012
  9. Matthijs KooijmanApr 26, 2012
  10. 1/2 git-svn: use platform specific auth providersMatthijs Kooijman, Apr 26, 2012
  11. 2/2 git-svn: Configure a prompt callback for gnome_keyring.Matthijs Kooijman, Apr 26, 2012
  12. Eric WongApr 27, 2012
  13. Matthijs KooijmanApr 27, 2012
  14. Matthijs KooijmanJun 18, 2013
  15. git-svn: Configure a prompt callback for gnome_keyring.Matthijs Kooijman, Jun 18, 2013
  16. Matthijs KooijmanAug 29, 2013
  17. Eric WongAug 29, 2013
  18. Matthijs KooijmanApr 27, 2012
  19. Eric WongApr 27, 2012
  20. Matthijs KooijmanApr 27, 2012
  21. Eric WongApr 29, 2012
  22. Junio C HamanoApr 30, 2012
  23. Junio C HamanoApr 30, 2012
  24. Eric WongApr 30, 2012
  25. Junio C HamanoApr 30, 2012
  26. Matthijs KooijmanApr 30, 2012
  27. Eric WongApr 30, 2012
  28. Matthijs KooijmanApr 30, 2012
  29. Junio C HamanoMay 1, 2012
  30. Charles BaileyJun 3, 2012
  31. Junio C HamanoJun 3, 2012
  32. Matthijs KooijmanJun 4, 2012
  33. Junio C HamanoJun 4, 2012
  34. Eric WongJun 4, 2012
  35. Eric WongAug 29, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.