Re: [PATCH 1/2] git-svn: use platform specific auth providers

From: Charles Bailey <charles@hashpling.org>
Date: Jun 3, 2012, 10:49 UTC
Message-ID: <20120603104914.GA21276@hashpling.org>
In-Reply-To: <7vy5pcd7xu.fsf@alter.siamese.dyndns.org>

On Mon, Apr 30, 2012 at 06:08:29PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> 
> Ok, something along the lines of this.  Perhaps instead of "compare_",
> we may want to call it "require_", so that negative return maps naturally
> to a failure.
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 427da9e..4a2ec43 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl

snip

Show 9 quoted lines

> @@ -5464,7 +5481,7 @@ sub _auth_providers () {
>  
>  	# earlier 1.6.x versions would segfault, and <= 1.5.x didn't have
>  	# this function
> -	if ($SVN::Core::VERSION gt '1.6.12') {
> +	if (compare_svn_version('1.6.12') > 0) {
>  		my $config = SVN::Core::config_get_config($config_dir);
>  		my ($p, @a);
>  		# config_get_config returns all config files from

I presume this patch turned into this commit:

commit f760c903b8525878cd3b426fc61a7a2cf8742609
Author: Junio C Hamano <gitster@pobox.com>
Date:   Wed May 2 19:53:50 2012 +0000

    git-svn: introduce SVN version comparison function

Although it was advertised as fixing the breakage introduced by 082afee621aeb2d3746c8ae290af98823f981f34 it didn't fix things for me. Although I haven't investigate why, trial and error proved that I could fix it if I changed the comparison to:

       if (::compare_svn_version('1.6.13') > 0) {

For me: $ svn --version --quiet 1.6.13

Is this the correct fix or do I have a bad svn install on my linux box?

Charles.