git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/9] Extending the shelf life of "git describe" output

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 19, 2012, 23:08 UTC
Message-ID
<7vfw9qyk6m.fsf@alter.siamese.dyndns.org>
In-Reply-To
<877gv34vtg.fsf@thomas.inf.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
Show 9 quoted lines
> Two random thoughts:
>
> * The commit_only flag is only one thing you may "know" about the
>   parsing, as you state above.  E.g., we may know the distance from a
>   certain tag.  Given this, wouldn't it be cleaner to patch a struct
>   things_we_know into the call chain instead of only a flag?
>
> * The treeish:path syntax also "knows" that the left side must be or
>   peel to a tree, so it makes no sense to go looking for a blob.

Both good. I take it to mean that we found a volunteer to take the ownership of the second idea to build on top of the series ;-)

Thanks.
Previous: Thomas RastNext: Thomas Rast
Message 13 of 14 in “Extending the shelf life of "git describe" output”
  1. 0/9 Extending the shelf life of "git describe" outputJunio C Hamano, Jun 18, 2012
  2. 1/9 sha1_name.c: indentation fixJunio C Hamano, Jun 18, 2012
  3. 2/9 sha1_name.c: clarify what "fake" is for in find_short_object_filename()Junio C Hamano, Jun 18, 2012
  4. 3/9 sha1_name.c: rename "now" to "current"Junio C Hamano, Jun 18, 2012
  5. 4/9 sha1_name.c: refactor find_short_packed_object()Junio C Hamano, Jun 18, 2012
  6. 5/9 sha1_name.c: teach find_short_object_filename() a commit-only optionJunio C Hamano, Jun 18, 2012
  7. 5/9 sha1_name.c: teach find_short_object_filename() a commit-only optionJunio C Hamano, Jun 18, 2012
  8. 6/9 sha1_name.c: teach find_short_packed_object() a commit-only optionJunio C Hamano, Jun 18, 2012
  9. 7/9 sha1_name.c: allow get_short_sha1() to take other flagsJunio C Hamano, Jun 18, 2012
  10. 8/9 sha1_name.c: teach get_short_sha1() a commit-only optionJunio C Hamano, Jun 18, 2012
  11. 9/9 sha1_name.c: get_describe_name() by definition groks only commitsJunio C Hamano, Jun 18, 2012
  12. Thomas RastJun 19, 2012
  13. Junio C HamanoJun 19, 2012
  14. Thomas RastJun 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.