git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/9] sha1_name.c: teach find_short_packed_object() a commit-only option

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 18, 2012, 22:05 UTC
Message-ID
<1340057139-8311-8-git-send-email-gitster@pobox.com>
In-Reply-To
<1340057139-8311-1-git-send-email-gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 sha1_name.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/sha1_name.c b/sha1_name.c
index a283c85..262d7e1 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -97,6 +97,7 @@ static int unique_in_pack(int len,
 			  const unsigned char *match,
 			  struct packed_git *p,
 			  const unsigned char **found_sha1,
+			  int commit_only,
 			  int seen_so_far)
 {
 	uint32_t num, last, i, first = 0;
@@ -134,6 +135,8 @@ static int unique_in_pack(int len,
 			break;
 
 		/* current matches */
+		if (commit_only && !is_commit_object(current))
+			continue;
 		if (!seen_so_far) {
 			*found_sha1 = current;
 			seen_so_far++;
@@ -146,7 +149,8 @@ static int unique_in_pack(int len,
 	return seen_so_far;
 }
 
-static int find_short_packed_object(int len, const unsigned char *match, unsigned char *sha1)
+static int find_short_packed_object(int len, const unsigned char *match,
+				    unsigned char *sha1, int commit_only)
 {
 	struct packed_git *p;
 	const unsigned char *found_sha1 = NULL;
@@ -154,7 +158,8 @@ static int find_short_packed_object(int len, const unsigned char *match, unsigne
 
 	prepare_packed_git();
 	for (p = packed_git; p && found < 2; p = p->next)
-		found = unique_in_pack(len, match, p, &found_sha1, found);
+		found = unique_in_pack(len, match, p, &found_sha1,
+				       commit_only, found);
 
 	if (found == 1)
 		hashcpy(sha1, found_sha1);
@@ -172,7 +177,7 @@ static int find_unique_short_object(int len, char *canonical,
 
 	prepare_alt_odb();
 	has_unpacked = find_short_object_filename(len, canonical, unpacked_sha1, 0);
-	has_packed = find_short_packed_object(len, res, packed_sha1);
+	has_packed = find_short_packed_object(len, res, packed_sha1, 0);
 	if (!has_unpacked && !has_packed)
 		return SHORT_NAME_NOT_FOUND;
 	if (1 < has_unpacked || 1 < has_packed)
-- 
1.7.11
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 14 in “Extending the shelf life of "git describe" output”
  1. 0/9 Extending the shelf life of "git describe" outputJunio C Hamano, Jun 18, 2012
  2. 1/9 sha1_name.c: indentation fixJunio C Hamano, Jun 18, 2012
  3. 2/9 sha1_name.c: clarify what "fake" is for in find_short_object_filename()Junio C Hamano, Jun 18, 2012
  4. 3/9 sha1_name.c: rename "now" to "current"Junio C Hamano, Jun 18, 2012
  5. 4/9 sha1_name.c: refactor find_short_packed_object()Junio C Hamano, Jun 18, 2012
  6. 5/9 sha1_name.c: teach find_short_object_filename() a commit-only optionJunio C Hamano, Jun 18, 2012
  7. 5/9 sha1_name.c: teach find_short_object_filename() a commit-only optionJunio C Hamano, Jun 18, 2012
  8. 6/9 sha1_name.c: teach find_short_packed_object() a commit-only optionJunio C Hamano, Jun 18, 2012
  9. 7/9 sha1_name.c: allow get_short_sha1() to take other flagsJunio C Hamano, Jun 18, 2012
  10. 8/9 sha1_name.c: teach get_short_sha1() a commit-only optionJunio C Hamano, Jun 18, 2012
  11. 9/9 sha1_name.c: get_describe_name() by definition groks only commitsJunio C Hamano, Jun 18, 2012
  12. Thomas RastJun 19, 2012
  13. Junio C HamanoJun 19, 2012
  14. Thomas RastJun 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.