git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/9] sha1_name.c: allow get_short_sha1() to take other flags

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 18, 2012, 22:05 UTC
Message-ID
<1340057139-8311-9-git-send-email-gitster@pobox.com>
In-Reply-To
<1340057139-8311-1-git-send-email-gitster@pobox.com>

Instead of a separate "int quietly" argument, make it take "unsigned flags" so that we can pass other options to it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 sha1_name.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/sha1_name.c b/sha1_name.c
index 262d7e1..df11ded 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -193,12 +193,15 @@ static int find_unique_short_object(int len, char *canonical,
 	return 0;
 }
 
+#define GET_SHORT_QUIETLY 01
+
 static int get_short_sha1(const char *name, int len, unsigned char *sha1,
-			  int quietly)
+			  unsigned flags)
 {
 	int i, status;
 	char canonical[40];
 	unsigned char res[20];
+	int quietly = !!(flags & GET_SHORT_QUIETLY);
 
 	if (len < MINIMUM_ABBREV || len > 40)
 		return -1;
@@ -240,7 +243,7 @@ const char *find_unique_abbrev(const unsigned char *sha1, int len)
 		return hex;
 	while (len < 40) {
 		unsigned char sha1_ret[20];
-		status = get_short_sha1(hex, len, sha1_ret, 1);
+		status = get_short_sha1(hex, len, sha1_ret, GET_SHORT_QUIETLY);
 		if (exists
 		    ? !status
 		    : status == SHORT_NAME_NOT_FOUND) {
@@ -571,7 +574,7 @@ static int get_describe_name(const char *name, int len, unsigned char *sha1)
 			if (ch == 'g' && cp[-1] == '-') {
 				cp++;
 				len -= cp - name;
-				return get_short_sha1(cp, len, sha1, 1);
+				return get_short_sha1(cp, len, sha1, GET_SHORT_QUIETLY);
 			}
 		}
 	}
-- 
1.7.11
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 14 in “Extending the shelf life of "git describe" output”
  1. 0/9 Extending the shelf life of "git describe" outputJunio C Hamano, Jun 18, 2012
  2. 1/9 sha1_name.c: indentation fixJunio C Hamano, Jun 18, 2012
  3. 2/9 sha1_name.c: clarify what "fake" is for in find_short_object_filename()Junio C Hamano, Jun 18, 2012
  4. 3/9 sha1_name.c: rename "now" to "current"Junio C Hamano, Jun 18, 2012
  5. 4/9 sha1_name.c: refactor find_short_packed_object()Junio C Hamano, Jun 18, 2012
  6. 5/9 sha1_name.c: teach find_short_object_filename() a commit-only optionJunio C Hamano, Jun 18, 2012
  7. 5/9 sha1_name.c: teach find_short_object_filename() a commit-only optionJunio C Hamano, Jun 18, 2012
  8. 6/9 sha1_name.c: teach find_short_packed_object() a commit-only optionJunio C Hamano, Jun 18, 2012
  9. 7/9 sha1_name.c: allow get_short_sha1() to take other flagsJunio C Hamano, Jun 18, 2012
  10. 8/9 sha1_name.c: teach get_short_sha1() a commit-only optionJunio C Hamano, Jun 18, 2012
  11. 9/9 sha1_name.c: get_describe_name() by definition groks only commitsJunio C Hamano, Jun 18, 2012
  12. Thomas RastJun 19, 2012
  13. Junio C HamanoJun 19, 2012
  14. Thomas RastJun 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.