Re: [PATCH/RFC] git-svn: don't create master if another head exists
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 26, 2012, 22:03 UTC
- Message-ID
- <7vfw9hafz8.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120626212108.GR3125@beczulka>
Marcin Owsiany <marcin@owsiany.pl> writes:
Show 11 quoted lines
> diff --git a/git-svn.perl b/git-svn.perl
> index 0b074c4..2379a71 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1612,9 +1612,9 @@ sub post_fetch_checkout {
> }
> }
>
> - my $valid_head = verify_ref('HEAD^0');
> + return if verify_ref('HEAD^0');
> command_noisy(qw(update-ref refs/heads/master), $gs->refname);Given that your original motivation was "I do not want master, I am using something else for my primary branch", I change that still shows "update-ref refs/heads/master" smells like sweeping something under the rug (i.e. repeated "oh, running this verison still fails here, so I'll patch it up" hackery without a solid grand design).
Show 7 quoted lines
> - return if ($valid_head || !verify_ref('HEAD^0'));
> + return unless verify_ref('HEAD^0');
>
> return if $ENV{GIT_DIR} !~ m#^(?:.*/)?\.git$#;
> my $index = $ENV{GIT_INDEX_FILE} || "$ENV{GIT_DIR}/index";
> --
> 1.7.7.3