git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] git-svn: don't create master if another head exists

From
EWEric Wong <normalperson@yhbt.net>
Date
Jul 18, 2012, 11:27 UTC
Message-ID
<20120718112722.GA22042@dcvr.yhbt.net>
In-Reply-To
<20120718074908.GA23460@beczulka>
Marcin Owsiany <marcin@owsiany.pl> wrote:
Show 13 quoted lines
> On Wed, Jul 11, 2012 at 03:56:43PM -0700, Junio C Hamano wrote:
> > If the caller does not handle errors, it could be even clearer to
> > write it like
> > 
> > 	command_noisy(qw(update-ref HEAD), $gs->refname) ||
> > 		die "Cannot update HEAD!!!";
> 
> Turns out that command_noisy()
>  - has a meaningless return value
>  - throws an exception on command failure
> so the "||" bit does not work.
> Also, for some reason command_noisy does not check for the command being
> killed by a signal, so I'd prefer to leave the verify_ref there.

Ugh, I always forget the Git.pm API, too. Perhaps command_noisy should be made to respect signals in exit codes (the rest of git-svn is compromised by this behavior in command_noisy, too, it turns out... :x)

I'm not sure what else would break if command_noisy were changed, git-svn appears to be the only user in git.git.

Previous: Marcin OwsianyNext: Marcin Owsiany
Message 19 of 23 in “git-svn: don't create master if another head exists”
  1. git-svn: don't create master if another head existsMarcin Owsiany, Jun 24, 2012
  2. Eric WongJun 25, 2012
  3. Junio C HamanoJun 25, 2012
  4. Marcin OwsianyJun 25, 2012
  5. Junio C HamanoJun 25, 2012
  6. Marcin OwsianyJun 25, 2012
  7. Junio C HamanoJun 25, 2012
  8. Marcin OwsianyJun 25, 2012
  9. Junio C HamanoJun 25, 2012
  10. Marcin OwsianyJun 26, 2012
  11. Junio C HamanoJun 26, 2012
  12. Marcin OwsianyJun 26, 2012
  13. Marcin OwsianyJul 9, 2012
  14. Junio C HamanoJul 9, 2012
  15. Eric WongJul 11, 2012
  16. Marcin OwsianyJul 11, 2012
  17. Junio C HamanoJul 11, 2012
  18. Marcin OwsianyJul 18, 2012
  19. Eric WongJul 18, 2012
  20. Marcin OwsianyJul 18, 2012
  21. Eric WongJul 19, 2012
  22. Junio C HamanoJul 19, 2012
  23. Junio C HamanoJul 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.