Re: [PATCH/RFC] git-svn: don't create master if another head exists

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 19, 2012, 08:19 UTC
Message-ID: <20120719081935.GA15414@dcvr.yhbt.net>
In-Reply-To: <20120718124723.GA17379@beczulka>

Marcin Owsiany <marcin@owsiany.pl> wrote:

Show 17 quoted lines

> On Wed, Jul 18, 2012 at 11:27:22AM +0000, Eric Wong wrote:
> > Marcin Owsiany <marcin@owsiany.pl> wrote:
> > > Turns out that command_noisy()
> > >  - has a meaningless return value
> > >  - throws an exception on command failure
> > > so the "||" bit does not work.
> > > Also, for some reason command_noisy does not check for the command being
> > > killed by a signal, so I'd prefer to leave the verify_ref there.
> > 
> > Ugh, I always forget the Git.pm API, too.  Perhaps command_noisy should
> > be made to respect signals in exit codes (the rest of git-svn is
> > compromised by this behavior in command_noisy, too, it turns out... :x)
> > 
> > I'm not sure what else would break if command_noisy were changed,
> > git-svn appears to be the only user in git.git.
> 
> Other "command" flavours should probably also be changed to match?

Probably, I'm not sure if it'd break existing uses. Anyways, that's a separate issue we can deal with another day.

I've added my Signed-off-by: to your latest patch and pushed to "master" of git://bogomips.org/git-svn.git (commit e3bd4ddaa9a60fa4e70efdb143b434b440d6cec4)

Marcin Owsiany (1):
      git-svn: don't create master if another head exists