Re: [PATCH 1/2] advice: extract function to print messages with prefix

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 7, 2012, 20:52 UTC
Message-ID: <7vfw6two6o.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAN0XMOK5QnNn8471RF4y7u_X0rfda=-J-KrCtyMsgCGHXNrwVw@mail.gmail.com>

Ralf Thielow <ralf.thielow@gmail.com> writes:

Show 17 quoted lines

> On Fri, Sep 7, 2012 at 9:32 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>>> -             fprintf(stderr, _("hint: %.*s\n"), (int)(np - cp), cp);
>>> +             fprintf(stderr,  "%s %.*s\n", prefix, (int)(np - cp), cp);
>>
>> Hrm, naively, printf("%s: %.*s\n", _("hint"), ...) might look more
>> natural, but I vaguely recall that the current code places _()
>> around the entire "hint: %.*s\n" on purpose.  IIRC, it was to allow
>> translations that flow from RTL e.g. ".siht od t'nod :tnih".
>>
>> Doesn't this patch break it?
>
> Sorry but I don't know what you mean with "translations that flow
> from RTL e.g. ".siht od t'nod :tnih"." so I can't check this.
> As far as I can see the callers only put a simple message in it,
> e.g. advise(_("Commit your changes or stash them to proceed."));
> So I don't think that this patch would break anything.

Your patch would not allow target languages that want to put the _("hint") at the *tail* end of each line of the message. With the original, with something like this:

	msgid "hint: %.*s\n"
        msgstr "%.*s :tnih\n"

you could do that if you wanted to.