git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Patch 1/5] Fix some asciidoc layout problems

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 6, 2012, 18:39 UTC
Message-ID
<7vfw5rqwby.fsf@alter.siamese.dyndns.org>
In-Reply-To
<244418682.269701.1349538839518.JavaMail.ngmail@webmail08.arcor-online.net>
Thomas Ackermann <th.acker66@arcor.de> writes:
Show 5 quoted lines
> Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
> ---
>  Documentation/git-bisect-lk2009.txt | 12 ++++++------
>  Documentation/git-fetch-pack.txt    |  5 ++++-
>  2 files changed, 10 insertions(+), 7 deletions(-)

You didn't say what "layout problem" you are fixing, or what the approach you took to "fix" it. From the patch, I can guess that the latter is to lengthen the lines that surround the displayed examples, but as far as I know and can tell, the existing ones are long enough so I cannot tell why you needed such a change to the source in the first place.

A better explanation, please?

The synopsis section of git-fetch-pack manual is a long single line which is unsightly. A fix to that issue is indeed needed. Please make a separate patch only for that issue. Is git-fetch-pack the only one whose synopsis section is overlong, by the way?

Thanks.
Show 62 quoted lines
>
> diff --git a/Documentation/git-bisect-lk2009.txt b/Documentation/git-bisect-lk2009.txt
> index 8a2ba37..99bdb46 100644
> --- a/Documentation/git-bisect-lk2009.txt
> +++ b/Documentation/git-bisect-lk2009.txt
> @@ -248,7 +248,7 @@ Bisecting: 5480 revisions left to test after this (roughly 13 steps)
>  And after a few more steps like that, "git bisect" will eventually
>  find a first bad commit:
>  
> --------------
> +------------------------------------------------------------------------------------------------------------
>  $ git bisect bad
>  2ddcca36c8bcfa251724fe342c8327451988be0d is the first bad commit
>  commit 2ddcca36c8bcfa251724fe342c8327451988be0d
> @@ -257,8 +257,8 @@ Date:   Sat May 3 11:59:44 2008 -0700
>  
>      Linux 2.6.26-rc1
>  
> -:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M      Makefile
> --------------
> +:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M  Makefile
> +------------------------------------------------------------------------------------------------------------
>  
>  At this point we can see what the commit does, check it out (if it's
>  not already checked out) or tinker with it, for example:
> @@ -305,7 +305,7 @@ to launch a script or command at each bisection step to know if the
>  current commit is "good" or "bad". To do that, we use the "git bisect
>  run" command. For example:
>  
> --------------
> +------------------------------------------------------------------------------------------------------------
>  $ git bisect start v2.6.27 v2.6.25
>  Bisecting: 10928 revisions left to test after this (roughly 14 steps)
>  [2ec65f8b89ea003c27ff7723525a2ee335a2b393] x86: clean up using max_low_pfn on 32-bit
> @@ -331,9 +331,9 @@ Date:   Sat May 3 11:59:44 2008 -0700
>  
>      Linux 2.6.26-rc1
>  
> -:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M      Makefile
> +:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M  Makefile
>  bisect run success
> --------------
> +------------------------------------------------------------------------------------------------------------
>  
>  In this example, we passed "grep '^SUBLEVEL = 25' Makefile" as
>  parameter to "git bisect run". This means that at each step, the grep
> diff --git a/Documentation/git-fetch-pack.txt b/Documentation/git-fetch-pack.txt
> index 474fa30..12cd8a2 100644
> --- a/Documentation/git-fetch-pack.txt
> +++ b/Documentation/git-fetch-pack.txt
> @@ -9,7 +9,10 @@ git-fetch-pack - Receive missing objects from another repository
>  SYNOPSIS
>  --------
>  [verse]
> -'git fetch-pack' [--all] [--quiet|-q] [--keep|-k] [--thin] [--include-tag] [--upload-pack=<git-upload-pack>] [--depth=<n>] [--no-progress] [-v] [<host>:]<directory> [<refs>...]
> +'git fetch-pack' [--all] [--quiet|-q] [--keep|-k] [--thin] [--include-tag] 
> +				[--upload-pack=<git-upload-pack>] 
> +				[--depth=<n>] [--no-progress] 
> +				[-v] [<host>:]<directory> [<refs>...]
>  
>  DESCRIPTION
>  -----------
Previous: Thomas AckermannNext: Jeff King
Message 3 of 23 in “Create single PDF for all HTML files”
  1. 0/5 Create single PDF for all HTML filesThomas Ackermann, Oct 6, 2012
  2. 1/5 Fix some asciidoc layout problemsThomas Ackermann, Oct 6, 2012
  3. Junio C HamanoOct 6, 2012
  4. Jeff KingOct 6, 2012
  5. Aw: Re: [Patch 1/5] Fix some asciidoc layout problemsThomas Ackermann, Oct 7, 2012
  6. 2/5 Create html documents for all files in Documentation/technicalThomas Ackermann, Oct 6, 2012
  7. Philip OakleyOct 6, 2012
  8. 3/5 Create html documents for all files in Documentation/RelNotesThomas Ackermann, Oct 6, 2012
  9. Philip OakleyOct 6, 2012
  10. Jeff KingOct 6, 2012
  11. Junio C HamanoOct 7, 2012
  12. Michael J GruberOct 15, 2012
  13. Junio C HamanoOct 15, 2012
  14. 4/5 Create html documents for all files in Documentation/howtoThomas Ackermann, Oct 6, 2012
  15. 5/5 Create pdf from all html filesThomas Ackermann, Oct 6, 2012
  16. Jeff KingOct 6, 2012
  17. Jeff KingOct 6, 2012
  18. Aw: Re: [Patch 0/5] Create single PDF for all HTML filesThomas Ackermann, Oct 7, 2012
  19. Jeff KingOct 7, 2012
  20. Michael J GruberOct 15, 2012
  21. Jeff KingOct 15, 2012
  22. Philip OakleyOct 8, 2012
  23. Junio C HamanoOct 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.