Re: [Patch 2/5] Create html documents for all files in Documentation/technical

From: Philip Oakley <philipoakley@iee.org>
Date: Oct 6, 2012, 18:45 UTC
Message-ID: <3662216A9D714C08B8522340D420AEEA@PhilipOakley>
In-Reply-To: <652323221.269712.1349538906380.JavaMail.ngmail@webmail08.arcor-online.net>

From: "Thomas Ackermann" <th.acker66@arcor.de>

Show 25 quoted lines

>- add missing files
> - fix some asciidoc layout problems
>
> Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
> ---
> Documentation/Makefile                    | 12 ++++++++++-
> Documentation/technical/index-format.txt  |  2 +-
> Documentation/technical/pack-format.txt   |  8 +++----
> Documentation/technical/pack-protocol.txt |  7 +++---
> Documentation/technical/shallow.txt       |  8 ++++++-
> Documentation/technical/trivial-merge.txt | 36 
> +++++++++++++++----------------
> 6 files changed, 45 insertions(+), 28 deletions(-)
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 267dfe1..86594f6 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -25,6 +25,16 @@ SP_ARTICLES += howto/revert-branch-rebase
> SP_ARTICLES += howto/using-merge-subtree
> SP_ARTICLES += howto/using-signed-tag-in-pull-request
> API_DOCS = $(patsubst %.txt,%,$(filter-out 
> technical/api-index-skel.txt technical/api-index.txt, $(wildcard 
> technical/api-*.txt)))
> +API_DOCS += technical/index-format

Would it not be better to create a separate TECH_DOCS list, rather than confuse the API_DOCS list?

Show 33 quoted lines

> +API_DOCS += technical/pack-format
> +API_DOCS += technical/pack-heuristics
> +API_DOCS += technical/pack-protocol
> +API_DOCS += technical/protocol-capabilities
> +API_DOCS += technical/protocol-common
> +API_DOCS += technical/racy-git
> +API_DOCS += technical/send-pack-pipeline
> +API_DOCS += technical/shallow
> +API_DOCS += technical/trivial-merge
> SP_ARTICLES += $(API_DOCS)
> SP_ARTICLES += technical/api-index
>
> @@ -231,7 +241,7 @@ clean:
>  $(RM) *.texi *.texi+ *.texi++ git.info gitman.info
>  $(RM) *.pdf
>  $(RM) howto-index.txt howto/*.html doc.dep
> - $(RM) technical/api-*.html technical/api-index.txt
> + $(RM) technical/*.html technical/api-index.txt
>  $(RM) $(cmds_txt) *.made
>  $(RM) manpage-base-url.xsl
>
> diff --git a/Documentation/technical/index-format.txt 
> b/Documentation/technical/index-format.txt
> index 9d25b30..57d6f91 100644
> --- a/Documentation/technical/index-format.txt
> +++ b/Documentation/technical/index-format.txt
> @@ -1,7 +1,7 @@
> GIT index format
> ================
>
> -= The git index file has the following format
> +== The git index file has the following format
>

<snip>