git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Patch 1/5] Fix some asciidoc layout problems

From
Jeff King <peff@peff.net>
Date
Oct 6, 2012, 19:10 UTC
Message-ID
<20121006191009.GB3644@sigill.intra.peff.net>
In-Reply-To
<7vfw5rqwby.fsf@alter.siamese.dyndns.org>
On Sat, Oct 06, 2012 at 11:39:13AM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Thomas Ackermann <th.acker66@arcor.de> writes:
> 
> > Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
> > ---
> >  Documentation/git-bisect-lk2009.txt | 12 ++++++------
> >  Documentation/git-fetch-pack.txt    |  5 ++++-
> >  2 files changed, 10 insertions(+), 7 deletions(-)
> 
> You didn't say what "layout problem" you are fixing, or what the
> approach you took to "fix" it.  From the patch, I can guess that the
> latter is to lengthen the lines that surround the displayed examples,
> but as far as I know and can tell, the existing ones are long enough
> so I cannot tell why you needed such a change to the source in the
> first place.
> 
> A better explanation, please?

I had the same question. Also, some of the lines convert tabs in literal output into spaces, which is actively wrong (or maybe they were converted already to spaces in the current code, but they should at least align with 8-space tabstops):

> > -:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M      Makefile
> > +:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M  Makefile
-Peff
Previous: Junio C HamanoNext: Thomas Ackermann
Message 4 of 23 in “Create single PDF for all HTML files”
  1. 0/5 Create single PDF for all HTML filesThomas Ackermann, Oct 6, 2012
  2. 1/5 Fix some asciidoc layout problemsThomas Ackermann, Oct 6, 2012
  3. Junio C HamanoOct 6, 2012
  4. Jeff KingOct 6, 2012
  5. Aw: Re: [Patch 1/5] Fix some asciidoc layout problemsThomas Ackermann, Oct 7, 2012
  6. 2/5 Create html documents for all files in Documentation/technicalThomas Ackermann, Oct 6, 2012
  7. Philip OakleyOct 6, 2012
  8. 3/5 Create html documents for all files in Documentation/RelNotesThomas Ackermann, Oct 6, 2012
  9. Philip OakleyOct 6, 2012
  10. Jeff KingOct 6, 2012
  11. Junio C HamanoOct 7, 2012
  12. Michael J GruberOct 15, 2012
  13. Junio C HamanoOct 15, 2012
  14. 4/5 Create html documents for all files in Documentation/howtoThomas Ackermann, Oct 6, 2012
  15. 5/5 Create pdf from all html filesThomas Ackermann, Oct 6, 2012
  16. Jeff KingOct 6, 2012
  17. Jeff KingOct 6, 2012
  18. Aw: Re: [Patch 0/5] Create single PDF for all HTML filesThomas Ackermann, Oct 7, 2012
  19. Jeff KingOct 7, 2012
  20. Michael J GruberOct 15, 2012
  21. Jeff KingOct 15, 2012
  22. Philip OakleyOct 8, 2012
  23. Junio C HamanoOct 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.