git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/5] config: make parsing stack struct independent from actual data source

From
Junio C Hamano <gitster@pobox.com>
Date
May 13, 2013, 04:56 UTC
Message-ID
<7vfvxrscjc.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130511132013.GD17991@book-mint>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 8 quoted lines
>  /*
> - * The fields f and name of top need to be initialized before calling
> + * All source specific fields in the union, name and the callbacks
> + * fgetc, ungetc, ftell of top need to be initialized before calling
>   * this function.
>   */
> -static int do_config_from(struct config_file *top, config_fn_t fn, void *data)
> +static int do_config_from_source(struct config_source *top, config_fn_t fn, void *data)

This renaming may have made sense if we were to have many different do_config_from_$type functions for different types of source, but as this patch introduces a nice "config_source" abstraction, I do not think it is unnecessary. Shortening do_config_from() to do_config() may make more sense, if anything.

But that is a very minor point, as this is entirely internal with a single caller.

Previous: Heiko VoigtNext: Heiko Voigt
Message 5 of 11 in “allow more sources for config values”
  1. 0/5 allow more sources for config valuesHeiko Voigt, May 11, 2013
  2. 1/5 config: factor out config file stack managementHeiko Voigt, May 11, 2013
  3. 2/5 config: drop cf validity check in get_next_char()Heiko Voigt, May 11, 2013
  4. 3/5 config: make parsing stack struct independent from actual data sourceHeiko Voigt, May 11, 2013
  5. Junio C HamanoMay 13, 2013
  6. Heiko VoigtMay 13, 2013
  7. Junio C HamanoMay 13, 2013
  8. Jeff KingMay 14, 2013
  9. 4/5 teach config --blob option to parse config from databaseHeiko Voigt, May 11, 2013
  10. 5/5 do not die when error in config parsing of buf occursHeiko Voigt, May 11, 2013
  11. Junio C HamanoJul 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.