From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 13 May 2013 04:56:39 GMT
Subject: Re: [PATCH v4 3/5] config: make parsing stack struct independent from actual data source
Message-ID: <7vfvxrscjc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130511132013.GD17991@book-mint>

Heiko Voigt <hvoigt@hvoigt.net> writes:

>  /*
> - * The fields f and name of top need to be initialized before calling
> + * All source specific fields in the union, name and the callbacks
> + * fgetc, ungetc, ftell of top need to be initialized before calling
>   * this function.
>   */
> -static int do_config_from(struct config_file *top, config_fn_t fn, void *data)
> +static int do_config_from_source(struct config_source *top, config_fn_t fn, void *data)

This renaming may have made sense if we were to have many different
do_config_from_$type functions for different types of source, but as
this patch introduces a nice "config_source" abstraction, I do not
think it is unnecessary. Shortening do_config_from() to do_config()
may make more sense, if anything.

But that is a very minor point, as this is entirely internal with a
single caller.