git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: [PATCH v4 3/5] config: make parsing stack struct independent from actual data source

From
Jeff King <peff@peff.net>
Date
May 14, 2013, 02:35 UTC
Message-ID
<20130514023551.GB23146@sigill.intra.peff.net>
In-Reply-To
<20130513140435.GC3561@book-mint>
On Mon, May 13, 2013 at 04:04:35PM +0200, Heiko Voigt wrote:
Show 6 quoted lines
> > > -static int do_config_from(struct config_file *top, config_fn_t fn, void *data)
> > > +static int do_config_from_source(struct config_source *top, config_fn_t fn, void *data)
> [...]
> I thought I recalled that Jeff asked me to change the name but I can
> not find the email, so maybe its just my wrong memory. I am happy to
> drop the rename here, if thats what you meant.
I think you are thinking of:
  http://thread.gmane.org/gmane.comp.version-control.git/217018/focus=217170

where I criticize the name. But I think the comment you added makes its purpose much more clear, so the name is less important (and for the record, I think "do_config" or "config_source_parse" would be fine, too).

-Peff
Previous: Junio C HamanoNext: Heiko Voigt
Message 8 of 11 in “allow more sources for config values”
  1. 0/5 allow more sources for config valuesHeiko Voigt, May 11, 2013
  2. 1/5 config: factor out config file stack managementHeiko Voigt, May 11, 2013
  3. 2/5 config: drop cf validity check in get_next_char()Heiko Voigt, May 11, 2013
  4. 3/5 config: make parsing stack struct independent from actual data sourceHeiko Voigt, May 11, 2013
  5. Junio C HamanoMay 13, 2013
  6. Heiko VoigtMay 13, 2013
  7. Junio C HamanoMay 13, 2013
  8. Jeff KingMay 14, 2013
  9. 4/5 teach config --blob option to parse config from databaseHeiko Voigt, May 11, 2013
  10. 5/5 do not die when error in config parsing of buf occursHeiko Voigt, May 11, 2013
  11. Junio C HamanoJul 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.