Re: fetching packs and storing them as packs

From: Junio C Hamano <junkio@cox.net>
Date: Oct 29, 2006, 04:29 UTC
Message-ID: <7vejsr68y9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061029035025.GC3435@spearce.org>

Shawn Pearce <spearce@spearce.org> writes:

Show 5 quoted lines

> The issue is --unpacked= uses the path of the pack name, which
> includes $GIT_OBJECT_DIRECTORY, whatever that may be.  This makes it
> impossible for the shell script to hand through a proper --unpacked=
> line for the active packs without including $GIT_OBJECT_DIRECTORY
> as part of the option.

Yeah, I realize that; you need to know how to build shell script that is properly shell quoted to be eval'ed, which is not hard but is not usually done and is cumbersome.

I would suspect it is probably easier to just say --unpacked (without packname) means "unpacked objects, and objects in packs that do not have corresponding .keep". However, that would be a change in semantics for --unpacked (without packname), which is not nice.

So how about pack-X{40}.volatile that marks an eligible one for repacking?

Then we can make "pack-objects --unpacked" to pretend the ones with corresponding .volatile as if the objects in them are loose, without breaking backward compatibility.

Show 5 quoted lines

> However on the git.git repository if I ran `git repack -a -d`
> with every single object in a kept pack and no loose objects I
> kept repacking the same 102 objects into a new active pack,
> even though there were no loose objects to repack and no
> active packs.  Uh, yea.

Will take a look myself if you are otherwise busy.