git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bundle, fast-import: detect write failure

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 11, 2008, 07:36 UTC
Message-ID
<7vejco4xv5.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<87hchlhm3k.fsf@rho.meyering.net>
Jim Meyering <jim@meyering.net> writes:
> On the other hand, if that write failure is truly ignorable,
> a mindless minimalist :-) might argue that it's best just to
> omit the syscall.

Usually the contents of .keep file is a small one-line comment that describes who decided that the pack needs to be kept and why, so the answer is no.

In this case, a failure while closing that small .keep file is highly unlikely, and if we ever mange to trigger such a highly unlikely failure, I think we would rather want to *know* about it, as it is likely there is something more seriously wrong going on.

So let's keep that check on close().
Previous: Jakub NarebskiNext: David Tweed
Message 11 of 13 in “bundle, fast-import: detect write failure”
  1. bundle, fast-import: detect write failureJim Meyering, Jan 10, 2008
  2. Pierre HabouzitJan 10, 2008
  3. Johannes SchindelinJan 10, 2008
  4. Jim MeyeringJan 10, 2008
  5. Johannes SchindelinJan 10, 2008
  6. Jim MeyeringJan 10, 2008
  7. Pierre HabouzitJan 10, 2008
  8. Jim MeyeringJan 10, 2008
  9. Pierre HabouzitJan 10, 2008
  10. Jakub NarebskiJan 11, 2008
  11. Junio C HamanoJan 11, 2008
  12. David TweedJan 11, 2008
  13. Johannes SchindelinJan 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.