git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bundle, fast-import: detect write failure

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 11, 2008, 11:39 UTC
Message-ID
<Pine.LNX.4.64.0801111237540.14355@wbgn129.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7vejco4xv5.fsf@gitster.siamese.dyndns.org>
Hi,
On Thu, 10 Jan 2008, Junio C Hamano wrote:
Show 6 quoted lines
> In this case, a failure while closing that small .keep file is highly 
> unlikely, and if we ever mange to trigger such a highly unlikely 
> failure, I think we would rather want to *know* about it, as it is 
> likely there is something more seriously wrong going on.
> 
> So let's keep that check on close().

My comment was not about that _check_, but about having this die() instead of just printing out a warning.

If that close fails, strange things are going on, alright. But neither the open() nor the write() failed at that point, so IMO it would be a mistake to error out _here_. If later stages fail also, well, we can die() there, no?

Ciao, Dscho

Previous: David Tweed
Message 13 of 13 in “bundle, fast-import: detect write failure”
  1. bundle, fast-import: detect write failureJim Meyering, Jan 10, 2008
  2. Pierre HabouzitJan 10, 2008
  3. Johannes SchindelinJan 10, 2008
  4. Jim MeyeringJan 10, 2008
  5. Johannes SchindelinJan 10, 2008
  6. Jim MeyeringJan 10, 2008
  7. Pierre HabouzitJan 10, 2008
  8. Jim MeyeringJan 10, 2008
  9. Pierre HabouzitJan 10, 2008
  10. Jakub NarebskiJan 11, 2008
  11. Junio C HamanoJan 11, 2008
  12. David TweedJan 11, 2008
  13. Johannes SchindelinJan 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.