From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Jan 2008 07:36:46 GMT
Subject: Re: [PATCH] bundle, fast-import: detect write failure
Message-ID: <7vejco4xv5.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <87hchlhm3k.fsf@rho.meyering.net>

Jim Meyering <jim@meyering.net> writes:

> On the other hand, if that write failure is truly ignorable,
> a mindless minimalist :-) might argue that it's best just to
> omit the syscall.

Usually the contents of .keep file is a small one-line comment
that describes who decided that the pack needs to be kept and
why, so the answer is no.

In this case, a failure while closing that small .keep file is
highly unlikely, and if we ever mange to trigger such a highly
unlikely failure, I think we would rather want to *know* about
it, as it is likely there is something more seriously wrong
going on.

So let's keep that check on close().